src/message_pool/msgpool/provider.rs (1)

122-140: Add operation-specific context to error mapping.

At Line 129, Line 137, and Line 140, converting errors with e.to_string() drops step-level context, which makes runtime diagnosis harder.

Suggested patch

-                let lookback_ts = if ts.epoch() > self.chain_config().policy.chain_finality {
+                let finality = self.chain_config().policy.chain_finality;
+                let lookback_ts = if ts.epoch() > finality {
                     self.chain_index()
                         .tipset_by_height(
-                            ts.epoch() - self.chain_config().policy.chain_finality,
+                            ts.epoch() - finality,
                             ts.clone(),
                             ResolveNullTipset::TakeOlder,
                         )
-                        .map_err(|e| Error::Other(e.to_string()))?
+                        .map_err(|e| {
+                            Error::Other(format!(
+                                "failed loading lookback tipset at epoch {}: {e}",
+                                ts.epoch() - finality
+                            ))
+                        })?
                 } else {
                     // Matches the logic at <https://github.com/filecoin-project/lotus/blob/v1.35.1/chain/stmgr/stmgr.go#L361>
                     ts.clone()
                 };
 
                 let state =
                     StateTree::new_from_root(self.blockstore().clone(), lookback_ts.parent_state())
-                        .map_err(|e| Error::Other(e.to_string()))?;
+                        .map_err(|e| Error::Other(format!("failed building state tree: {e}")))?;
                 state
                     .resolve_to_deterministic_addr(self.blockstore(), *addr)
-                    .map_err(|e| Error::Other(e.to_string()))
+                    .map_err(|e| {
+                        Error::Other(format!(
+                            "failed resolving deterministic address at finality for {addr}: {e}"
+                        ))
+                    })

As per coding guidelines, “Use anyhow::Result<T> for most operations and add context with .context() when errors occur”.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/message_pool/msgpool/provider.rs` around lines 122 - 140, The error
mappings around the lookback/tipset and state resolution drop useful context;
update the calls that currently use map_err(|e| Error::Other(e.to_string())) for
tipset_by_height, StateTree::new_from_root, and
state.resolve_to_deterministic_addr to add operation-specific context (e.g.,
using anyhow::Context and .context("...") or otherwise wrapping the error with a
message) so failures include which step failed (computing lookback_ts via
tipset_by_height, constructing StateTree from parent_state, or resolving
deterministic address) and relevant values (epoch/chain_finality, parent_state,
addr); adjust the function signature to return anyhow::Result if needed.